Merging the Third Person Controller Course with the RPG Course

[Bahaa]

using RPG.Control;
using UnityEngine;

namespace RPG.States.Enemies 
{
    public class EnemyPatrolState : EnemyBaseState 
    {
        private const string NextPatrolPointIndexKey = "NextPatrolPointIndex";

        public EnemyPatrolState(EnemyStateMachine stateMachine) : base(stateMachine) {}

        private float movementSpeed = 0.5f;
        private float acceptanceRadius = 2f;
        private float dwellTime = 2f;
        private Vector3 targetPatrolPoint;

        public override void Enter()
        {
            if (stateMachine.PatrolPath == null) 
            {
                stateMachine.SwitchState(new EnemyIdleState(stateMachine));
                return;
            }

            int index;
            // Check blackboard for key, set index if key is set
            if (stateMachine.Blackboard.ContainsKey(NextPatrolPointIndexKey)) 
            {
                index = stateMachine.Blackboard.GetValueAsInt(NextPatrolPointIndexKey);
            }

            else 
            {
                // The first time we enter a Patrol state, the index will not be set in the blackboard
                // So we get it from the PatrolPath's GetNearestIndex
                // We will also be resetting the index if the enemy goes into 'EnemyChasingState.cs'
                index = stateMachine.PatrolPath.GetNearestIndex(stateMachine.transform.position);
            }

            // Set our goal
            targetPatrolPoint = stateMachine.PatrolPath.GetWaypoint(index);
            PatrolPoint patrolPoint = stateMachine.PatrolPath.GetPatrolPoint(index);

            if (patrolPoint) // If the current index has a PatrolPoint attached, then we can adjust the settings from the default
            {
                movementSpeed = stateMachine.MovementSpeed * patrolPoint.SpeedModifier;
                acceptanceRadius = patrolPoint.AcceptanceRadius;
                dwellTime = patrolPoint.DwellTime;
            }

            else // if not, calculate the movementSpeed as a percentage of the stateMachine's movement speed
            {
                movementSpeed *= stateMachine.MovementSpeed;
            }

            // Squaring the acceptanceRadius (to save calculation time when we use 'SqrMagnitude')
            acceptanceRadius *= acceptanceRadius;
            // next waypoint index setup
            stateMachine.Blackboard[NextPatrolPointIndexKey] = stateMachine.PatrolPath.GetNextIndex(index);
            // Since the waypoint won't move, set the destination here on the Agent
            stateMachine.Agent.SetDestination(targetPatrolPoint);
            // Set the animation
            stateMachine.Animator.CrossFadeInFixedTime(FreeLookBlendTreeHash, stateMachine.CrossFadeDuration);

        }

        public override void Tick(float deltaTime)
        {
            if (IsInChaseRange() && IsAggro()) // if you want to consider the optional aggregation, add "&& IsAggro()" to the if statement of this line
            {

                // if you want the vision system to work, uncomment the if statement below:

                // if (CanSeePlayer()) {
                // Clearing key to ensure that at the end of the battle, the enemy finds the nearest waypoint
                stateMachine.Blackboard.Remove(NextPatrolPointIndexKey);
                stateMachine.SwitchState(new EnemyChasingState(stateMachine));
                return;
                // }
            }

            if (IsInAcceptanceRange()) 
            {
                // Once we're close enough to the waypoint, we head to a Dwell state
                stateMachine.SwitchState(new EnemyDwellState(stateMachine, dwellTime));
                return;
            }

            // Chasing Code
            Vector3 lastPosition = stateMachine.transform.position;
            MoveToWayPoint(deltaTime);
            Vector3 deltaMovement = lastPosition - stateMachine.transform.position;
            float deltaMagnitude = deltaMovement.magnitude;
            float grossSpeed = deltaMagnitude / deltaTime;

            stateMachine.Animator.SetFloat(FreeLookSpeedHash, grossSpeed / stateMachine.MovementSpeed, stateMachine.AnimatorDampTime, deltaTime);
            if (deltaMagnitude > 0) 
            {
                FaceTarget(stateMachine.transform.position - deltaMovement, deltaTime);
            }
            else 
            {
                FaceTarget(targetPatrolPoint, deltaTime);
            }

        }

        private bool IsInAcceptanceRange() 
        {
            return (stateMachine.transform.position - targetPatrolPoint).sqrMagnitude < acceptanceRadius;
        }

        public override void Exit()
        {
            stateMachine.Agent.ResetPath();
            stateMachine.Agent.velocity = Vector3.zero;
        }

        void MoveToWayPoint(float deltaTime) 
        {
            Vector3 direction = stateMachine.Agent.desiredVelocity.normalized;
            Move(direction * movementSpeed, deltaTime);
            stateMachine.Agent.velocity = stateMachine.CharacterController.velocity;
            stateMachine.Agent.nextPosition = stateMachine.transform.position;
        }

    }
    
}

@Bahaa

Edit: Another bug I noticed (and this isn’t a bug, it’s just a system override), is that ‘Attack Force’ from ‘Attack.cs’ and ‘Weapon Damage’ in ‘WeaponConfig.cs’ are both dealing damage, so it adds them up… which one is safer to delete? I don’t want a mix and mash here

@Brian_Trotter

Try not passing the weapon damage in GetAdditiveModifiers within the WeaponConfig.

I need to remember to go back to this bug…

[Bahaa]

and before I forget, one last question regarding the respawning. What does deactivating and reactivating the character controller have to do with helping the chances of properly respawning?

[Brian_Trotter]

        public override void Exit()
        {
            if(stateMachine.agent.enabled)
            {
                stateMachine.Agent.ResetPath();
                stateMachine.Agent.velocity = Vector3.zero;
            }
        }

stateMachine.enabled=true;
stateMachine.Agent.SetDestination(targetPatrolPoint);

[Bahaa]

@Brian_Trotter

stateMachine.enabled=true;
stateMachine.Agent.SetDestination(targetPatrolPoint);

is that replacement or supplement code?

[Brian_Trotter]

I am confused, though, as to why the agent could be disabled between it working in Tick and being disabled in Exit for attacking…

@Bahaa

is that replacement or supplement code?

In Enter, find the line that sets the destination and enable the Agent (that should be stateMachine.Agent.enabled=true;, my bad)

[Bahaa]

the same errors are still showing up… (again though, I want to stress that they don’t hurt the game in any way shape or form, apart from the fact that the enemy attacks are still at a rapid pace and need breaks between them)

@Bahaa

and before I forget, one last question regarding the respawning. What does deactivating and reactivating the character controller have to do with helping the chances of properly respawning?

how about this question?

[Brian_Trotter]

@Bahaa

and before I forget, one last question regarding the respawning. What does deactivating and reactivating the character controller have to do with helping the chances of properly respawning?

While the CharacterController is active, it rejects changes to the transform outright, just like the NavMeshAgent does. In fact, that’s one of the reasons that the NavMeshAgent and the CharacterController don’t get along well and we have to manually call CharacterController.Move based on the Agent’s desiredVelocity.

[Bahaa]

@Brian_Trotter

While the CharacterController is active, it rejects changes to the transform outright

OK now I see why that bug was there… at first I thought I planted something somewhere and forgot to take it out, and when I deleted all sorts of movement when respawning and got my player to be where he was, I was even more shocked…

basically the rejection was because of the controller behind the scenes, got it

---

Another question on the fly, would deleting the mesh colliders on my weapons or shields hurt my attacks in any way? I deleted them last night because they were messing with Malbers’ animals (collider collisions), as in the colliders had the animals move in weird ways. They don’t seem to be doing so badly as we speak, but I still have to ask

---

@Bahaa

the same errors are still showing up…

any other ideas for this? That’s my script right now btw:

using RPG.Control;
using UnityEngine;

namespace RPG.States.Enemies 
{
    public class EnemyPatrolState : EnemyBaseState 
    {
        private const string NextPatrolPointIndexKey = "NextPatrolPointIndex";

        public EnemyPatrolState(EnemyStateMachine stateMachine) : base(stateMachine) {}

        private float movementSpeed = 0.5f;
        private float acceptanceRadius = 2f;
        private float dwellTime = 2f;
        private Vector3 targetPatrolPoint;

        public override void Enter()
        {
            if (stateMachine.PatrolPath == null) 
            {
                stateMachine.SwitchState(new EnemyIdleState(stateMachine));
                return;
            }

            int index;
            // Check blackboard for key, set index if key is set
            if (stateMachine.Blackboard.ContainsKey(NextPatrolPointIndexKey)) 
            {
                index = stateMachine.Blackboard.GetValueAsInt(NextPatrolPointIndexKey);
            }

            else 
            {
                // The first time we enter a Patrol state, the index will not be set in the blackboard
                // So we get it from the PatrolPath's GetNearestIndex
                // We will also be resetting the index if the enemy goes into 'EnemyChasingState.cs'
                index = stateMachine.PatrolPath.GetNearestIndex(stateMachine.transform.position);
            }

            // Set our goal
            targetPatrolPoint = stateMachine.PatrolPath.GetWaypoint(index);
            PatrolPoint patrolPoint = stateMachine.PatrolPath.GetPatrolPoint(index);

            if (patrolPoint) // If the current index has a PatrolPoint attached, then we can adjust the settings from the default
            {
                movementSpeed = stateMachine.MovementSpeed * patrolPoint.SpeedModifier;
                acceptanceRadius = patrolPoint.AcceptanceRadius;
                dwellTime = patrolPoint.DwellTime;
            }

            else // if not, calculate the movementSpeed as a percentage of the stateMachine's movement speed
            {
                movementSpeed *= stateMachine.MovementSpeed;
            }

            // Squaring the acceptanceRadius (to save calculation time when we use 'SqrMagnitude')
            acceptanceRadius *= acceptanceRadius;
            // next waypoint index setup
            stateMachine.Blackboard[NextPatrolPointIndexKey] = stateMachine.PatrolPath.GetNextIndex(index);
            // Enabling the NavMeshAgent
            stateMachine.enabled = true;
            // Since the waypoint won't move, set the destination here on the Agent
            stateMachine.Agent.SetDestination(targetPatrolPoint);
            // Set the animation
            stateMachine.Animator.CrossFadeInFixedTime(FreeLookBlendTreeHash, stateMachine.CrossFadeDuration);

        }

        public override void Tick(float deltaTime)
        {
            if (IsInChaseRange() && IsAggro()) // if you want to consider the optional aggregation, add "&& IsAggro()" to the if statement of this line
            {

                // if you want the vision system to work, uncomment the if statement below:

                // if (CanSeePlayer()) {
                // Clearing key to ensure that at the end of the battle, the enemy finds the nearest waypoint
                stateMachine.Blackboard.Remove(NextPatrolPointIndexKey);
                stateMachine.SwitchState(new EnemyChasingState(stateMachine));
                return;
                // }
            }

            if (IsInAcceptanceRange()) 
            {
                // Once we're close enough to the waypoint, we head to a Dwell state
                stateMachine.SwitchState(new EnemyDwellState(stateMachine, dwellTime));
                return;
            }

            // Chasing Code
            Vector3 lastPosition = stateMachine.transform.position;
            MoveToWayPoint(deltaTime);
            Vector3 deltaMovement = lastPosition - stateMachine.transform.position;
            float deltaMagnitude = deltaMovement.magnitude;
            float grossSpeed = deltaMagnitude / deltaTime;

            stateMachine.Animator.SetFloat(FreeLookSpeedHash, grossSpeed / stateMachine.MovementSpeed, stateMachine.AnimatorDampTime, deltaTime);
            if (deltaMagnitude > 0) 
            {
                FaceTarget(stateMachine.transform.position - deltaMovement, deltaTime);
            }
            else 
            {
                FaceTarget(targetPatrolPoint, deltaTime);
            }

        }

        private bool IsInAcceptanceRange() 
        {
            return (stateMachine.transform.position - targetPatrolPoint).sqrMagnitude < acceptanceRadius;
        }

        public override void Exit()
        {
            if (stateMachine.Agent.enabled) {            
            stateMachine.Agent.ResetPath();
            stateMachine.Agent.velocity = Vector3.zero;
            }
        }

        void MoveToWayPoint(float deltaTime) 
        {
            Vector3 direction = stateMachine.Agent.desiredVelocity.normalized;
            Move(direction * movementSpeed, deltaTime);
            stateMachine.Agent.velocity = stateMachine.CharacterController.velocity;
            stateMachine.Agent.nextPosition = stateMachine.transform.position;
        }

    }

}

[Bahaa]

@Bahaa

Edit: Another bug I noticed (and this isn’t a bug, it’s just a system override), is that ‘Attack Force’ from ‘Attack.cs’ and ‘Weapon Damage’ in ‘WeaponConfig.cs’ are both dealing damage, so it adds them up… which one is safer to delete? I don’t want a mix and mash here

@Brian_Trotter

Try not passing the weapon damage in GetAdditiveModifiers within the WeaponConfig.

speaking of this bug, I think I’ll be the black sheep here and eliminate the ‘Attack’ value instead. I want my attacks to be reliant on the weapon rather than on the animation - because of a few reasons:

1. My animations are more limited than my weapons
2. Upgrading weapons will make a whole lot more sense this way

I won’t delete it, but I will keep it as zero wherever I don’t want to apply it

[Brian_Trotter]

So this is what I have for the initial damage calculation in TryHit()

                    float damage = baseStats.GetStat(Stat.Damage);
                    damage *= currentAttack.DamageModifier;

So for this setup, the weapon damage is included in the GetStat(Stat.Damage) because the GetAdditiveModifiers returns the weapon damage.
Then that damage is multiplied by the attack’s modifier… so that some attacks can do more or less damage, a modifier of 1 is the same as the attack, .5f is 50% of the damage, 2f is double damage, etc.

You shouldn’t be hitting twice, only one TakeDamage should be called.

[Bahaa]

fair enough, so… I’ll keep those I don’t want as zero I guess

[Brian_Trotter]

0 * 1 =…
So that leaves the question of why you’re hitting twice… Do you have multiple TryHit animation events on the animation? Is there still a Hit animation event in your animation? Does your TryHit have multiple damage calls?

[Bahaa]

nope, we’re hitting twice because there’s a ‘WeaponDamage’ and an ‘AttackForce’ both exerting force… I like the weapon damage because of the easier name and that it’s directly accessible from when we are creating the weapon, but attack force is there as well, and I couldn’t be more baffled down the line

Anyway, I’m still trying to figure out the sudden character generator bug before we get back into adding new stuff

[Brian_Trotter]

Force is what flows through all living beings, and can be characterized as light or dar-- er… sorry, wrong movie.

Damage is applied to health and does… .damage
Force is applied to ForceReciever and should do… no damage…

[Bahaa]

you really love classic movies, don’t you? May the 4th be with you

OK so to recall before I go back to my annoying bug (which I am really clueless of how to solve, but I’m trying…):

• Attack Force is the force applied to the player, when they hit someone
• Hit force is the reaction force to push them back

… Right?

[Brian_Trotter]

That’s correct

[Bahaa]

good day to you too kind sir

Fair enough, for now I’ll let it be. Still trying to figure out what went wrong with my Synty models… - link

[Bahaa]

did I miss out on something with the Impact states…? When both me and my enemy try to return to idle state after we received a hit, we both literally freeze pretty much forever… As if the ‘HandleForceCompleted()’ function never unsubscribed to begin with… (and yes, I made sure it was in both ‘Enter’ and ‘Exit’ states of both the Impact States)

In ‘EnemyImpactState.cs’ (SPOILER), this script:

        using UnityEngine;

namespace RPG.States.Enemies {

    public class EnemyImpactState : EnemyBaseState
    {
        private readonly int ImpactHash = Animator.StringToHash("Impact");
        
        public EnemyImpactState(EnemyStateMachine stateMachine) : base(stateMachine) {}

        public override void Enter()
        {
            stateMachine.Animator.CrossFadeInFixedTime(ImpactHash, stateMachine.CrossFadeDuration);
            stateMachine.ForceReceiver.OnForceCompleted += HandleOnForceCompleted;
        }

        public override void Tick(float deltaTime)
        {
            Move(deltaTime);
        }

        public override void Exit()
        {
            stateMachine.ForceReceiver.OnForceCompleted -= HandleOnForceCompleted;
        }

        private void HandleOnForceCompleted() 
        {
            stateMachine.SwitchState(new EnemyIdleState(stateMachine));
        }
    }
}

and my ‘PlayerImpactState.cs’ (ANOTHER SPOILER):

using UnityEngine;

namespace RPG.States.Player {

    public class PlayerImpactState : PlayerBaseState
    {
        private readonly int ImpactHash = Animator.StringToHash("Impact");
        
        public PlayerImpactState(PlayerStateMachine stateMachine) : base(stateMachine) {}

        public override void Enter()
        {
            stateMachine.Animator.CrossFadeInFixedTime(ImpactHash, stateMachine.CrossFadeDuration);
            stateMachine.ForceReceiver.OnForceCompleted += HandleOnForceCompleted;
        }

        public override void Tick(float deltaTime)
        {
            Move(deltaTime);
        }

        public override void Exit()
        {
            stateMachine.ForceReceiver.OnForceCompleted -= HandleOnForceCompleted;
        }

        private void HandleOnForceCompleted() 
        {
            SetLocomotionState();
        }

    }

}

Placing debugs around seems to work, but… they both still freeze. I went through the tutorial twice so far, I still can’t find where I went wrong (apart from placing ‘HandleForceApplied’ in the StateMachine script (because the ‘Start()’ function needs that), instead of the ‘ImpactState’ scripts…

and I also have to mention that if we don’t give the ‘OnForceApplied’ event in ‘ForceReceiver.cs’ a type of Vector3, we will get errors, so this is how it’s written (since the force type using it in ‘AddForce’ is of type Vector3):

public event System.Action <Vector3> OnForceApplied;

without doing that, ‘Invoke’ won’t take in the force Input (the stuff bixarrio and you teach me… )

[Brian_Trotter]

It sounds like OnForceCompleted isn’t getting called…
Let’s take a look at your ForceReceiver.cs script…

[Bahaa]

using UnityEngine;

namespace RPG.Movement
{
    public class ForceReceiver : MonoBehaviour
    {
        [SerializeField] private float drag = 0.3f;
        [SerializeField] private float minimumImpactVelocity = 0.1f;
        
        private CharacterController controller;
        private UnityEngine.AI.NavMeshAgent agent;

        public event System.Action <Vector3> OnForceApplied;
        public event System.Action OnForceCompleted;

        bool forceActive;

        private void Awake()
        {
            controller = GetComponent<CharacterController>();
            agent = GetComponent<UnityEngine.AI.NavMeshAgent>();
        }

        private float verticalVelocity;

        private Vector3 impact;
        private Vector3 dampingVelocity;

        public Vector3 Movement => impact + Vector3.up * verticalVelocity;

        private void Update()
        {
            if (verticalVelocity < 0f && controller.isGrounded)
            {
                verticalVelocity = Physics.gravity.y * Time.deltaTime;
            }
            else
            {
                verticalVelocity += Physics.gravity.y * Time.deltaTime;
            }
            
            impact = Vector3.SmoothDamp(impact, Vector3.zero, ref dampingVelocity, drag);

            // if the squared magnitude of the impact is below the 'minimumImpactVelocity',
            // reset the impact and enable the agent (i.e: he took the impact, now get back to normal)
            if (forceActive) 
            {
                if (impact.sqrMagnitude < minimumImpactVelocity) 
                {
                    impact = Vector3.zero;
                    OnForceCompleted?.Invoke();
                    forceActive = false;
                    if (agent) agent.enabled = false;
                }
            }
        }

        public void AddForce(Vector3 force, bool triggerKnockbackEvent = false)
        {
            impact += force;
            if (agent) agent.enabled = false;
            if (triggerKnockbackEvent) OnForceApplied?.Invoke(force);
        }
    }
}