Try 1 is repeating

Karen_Pasqualucci · July 1, 2017, 10:39pm

Hi please can you help?
Expected behaviour : Each “Try” comes back with the current try number
Observed behaviour: Always just returns : “Try 1.”

My code compiles and runs and I have compared it to the notes several times. My guess is that it has to do with setting the int twice but I cannot find it }:

Here is the gist link:

gist.github.com

https://gist.github.com/anonymous/13c30845170af2c182330c64650d64eb.js

FBCG.cpp

#include "FBullCowGame.h"

int FBullCowGame::GetMaxTries() { return MyMaxTries; }

int FBullCowGame::GetCurrentTry() { return MyCurrentTry; }

void FBullCowGame::Reset()
{
	return;
}

This file has been truncated. show original

FBCG.h

#pragma once
#include <string>
class FBullCowGame 
{
public:
	void Reset(); //add more later
	int GetMaxTries();
	int GetCurrentTry();
	bool IsGameWon();
	bool CheckGuessValidity(std::string); //more later

This file has been truncated. show original

main.cpp

#include <iostream>
#include <string>
#include "FBullCowGame.h"



void PrintIntro();
void PlayGame();
std::string GetGuess();
bool AskToPlayAgain();

This file has been truncated. show original

Thanks!!

OldDauber · July 2, 2017, 6:19am

Hi, the github link you posted is not opening correctly, needs to be fixed so we can help

OldDauber · July 2, 2017, 4:19pm

EDIT: I think your correct github link would be this (just trimmed .js from the end) https://gist.github.com/anonymous/13c30845170af2c182330c64650d64eb

As to the original issue, I can’t see you incrementing MyCurrentTry in your code on each try that’s why it always shows the initial value of 1.

Karen_Pasqualucci · July 2, 2017, 3:49pm

gist.github.com

https://gist.github.com/anonymous/13c30845170af2c182330c64650d64eb

FBCG.cpp

#include "FBullCowGame.h"

int FBullCowGame::GetMaxTries() { return MyMaxTries; }

int FBullCowGame::GetCurrentTry() { return MyCurrentTry; }

void FBullCowGame::Reset()
{
	return;
}

This file has been truncated. show original

FBCG.h

#pragma once
#include <string>
class FBullCowGame 
{
public:
	void Reset(); //add more later
	int GetMaxTries();
	int GetCurrentTry();
	bool IsGameWon();
	bool CheckGuessValidity(std::string); //more later

This file has been truncated. show original

main.cpp

#include <iostream>
#include <string>
#include "FBullCowGame.h"



void PrintIntro();
void PlayGame();
std::string GetGuess();
bool AskToPlayAgain();

This file has been truncated. show original

Karen_Pasqualucci · July 2, 2017, 4:21pm

Thank you for the response! I appreciate the help. I have fixed the link.
I thought that the 4th line of Play the game was doing that? Isn’t it?

Here is the link to the lecture notes… with his changes and I cannot see where I have differed from his…

Later on… I stopped the lecture before it ended because I noticed the error. It is apparently supposed to be there at htis point whne I listened further. Thanks for the help @OldDauber !

OldDauber · July 2, 2017, 6:59pm

@Karen_Pasqualucci In this lecture MyCurrentTry is not being updated (and it is always 1 in the lecture code as well), it will be updated/incremented in a later lecture. So I’d say you’re all good at this point