Please poke holes in my logic

Unity Courses Talk
,
1

My way of dealing with the last 3 frames. I like it because there’s only one return for each type of action. Where can this fail?

    if (bowl >= 19 && Bowl21Awarded())
    {
        if (bowl == 20 && bowls[19 - 1] == 10 && pins < 10) // Frame 19 is a strike, and frame 20 isn't
        {
            bowl++;
            return Action.Tidy;
        }
        bowl++;
        return Action.Reset;
    }
    else if (bowl == 20 && !Bowl21Awarded())
    {
        return Action.EndGame;
    }
1 Like
2

Unless there’s more code for these frames that you’ve omitted, the game will never end if you earn the 21st bowl.