My ProcessGuess() is not a const ref function

mortalwombat · June 2, 2020, 5:36pm

My ProcessGuess() changes UserGuess input by converting any upper case characters to lower case. Is this acceptable? An alternative would be to create and alter a copy of UserGuess.
Thanks.

DanM · February 18, 2021, 12:01pm

Either that or call ToLowerInline before calling OnInput in the Terminal.cpp here

github.com

UnrealCourse2019/BullCowGame/blob/master/BullCowGame-starter-kit/Source/BullCowGame/Console/Terminal.cpp#L141


	UpdateText();
}


void UTerminal::AcceptInputLine()
{
	Buffer.Emplace(GPrompt + InputLine);
	auto Cartridge = GetOwner()->FindComponentByClass<UCartridge>();
	if (Cartridge != nullptr)
	{
		Cartridge->OnInput(InputLine);
	}
	InputLine = TEXT("");

}

void UTerminal::Backspace()
{
	if (InputLine.Len() > 0)
	{
		InputLine.RemoveAt(InputLine.Len()-1);

mortalwombat · June 3, 2020, 10:44am

Brilliant . Thank you. Never would have visited other files otherwise. The new implementation did interrupt my flow of logic because I think validating the word length and validating the characters before converting to lower case would be more efficient. Your thoughts?

DanM · June 3, 2020, 2:19pm

You would be right so it might be preferable to make it a non-const reference in your case.

system · November 24, 2020, 12:54pm

system · February 18, 2021, 12:01pm

This topic was automatically closed 24 hours after the last reply. New replies are no longer allowed.