If Statement to choose Shortest Route Incomplete

[Kyle_Wolfe]

Hi everyone, so after going through this video I noticed an issue with my tank in-game.

Moving right-to-left across the 180* mark works just fine and the barrel correctly chooses the shortest path to rotate.
Moving left-to-right across the 180* mark DOESN’T work as the if statement is incomplete.

I anded a check for greater than negative 180 like this:
((DeltaRotator.Yaw <= 180) && (DeltaRotator.Yaw >= -180))

After rewatching the video I think this left-to-right issue is visible there.

Thanks.

[DanM]

This has been noted and check here for @ben’s solution:

Section Production Progress

Thanks Dan, so I've managed to reproduce it my end now. Well-done finding that solution. I'm a bit reluctant to put 2 special cases in as we're approaching the complexity of the coordinate-transform solution. The simple introduction of FMath::Abs() works though, basically saying "avoid reflex angles"… if (FMath::Abs(DeltaRotator.Yaw) < 180) { Turret->Rotate(DeltaRotator.Yaw); } else { Turret->Rotate(-DeltaRotator.Yaw); } However, this whole approach only works if the tank isn't on it's …

[ben]

Thanks Kyle I’m going to make a patch to the video now to give people a heads up. We will solve this issue in the next couple of videos

[norlin]

Why just don’t take DeltaRorator.GetNormalized().Yaw? It looks like proper solution, unless I’ve missed some side-effects…

[DanM]

Both should be fine as they should achieve the same thing.