First of all, I’d like to say that I’ve learned a lot in this course!
My code is pretty much identical to that of the videos (except for renaming the spin action to a reload action), yet it’s instantiating the white GridSystemVisualSingle in all of the squares. The recoloring still works for all the actions, though. Any idea what’s going on?
I’ve also waited on implementing the health system visuals, as I was having issues there as well, but that’ll have to wait until another post.
It looks like your prefab has the visual active. That’s not necessarily a bad thing, especially when you’re prototyping and editing the visual in Prefab mode.
You can make it so that the GridSystemVisualSingle turns off the renderer when the prefab is instantiated by adding this method to GridSystemVisualSingle:
void Awake()
{
Hide();
}
Hello, thank you for your response.
This didn’t work, though.
Please help.
If that didn’t work, then something is purposely turning ON the GridSystemVisualSingle…
Paste in your GridSystemVisual.cs script and your GridSystemVisualSingle scripts. Please paste the text itself, not screenshots.
Here is the GridSystemVisual:
using System;
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class GridSystemVisual : MonoBehaviour
{
public static GridSystemVisual Instance { get; private set; }
[Serializable]
public struct GridVisualTypeMaterial
{
public GridVisualType gridVisualType;
public Material material;
}
public enum GridVisualType
{
White,
Blue,
Red,
RedSoft,
Yellow,
}
[SerializeField] private Transform gridSystemVisualSinglePrefab;
[SerializeField] private List<GridVisualTypeMaterial> gridVisualTypeMaterialList;
private GridSystemVisualSingle[,] gridSystemVisualSingleArray;
private void Awake()
{
if (Instance != null)
{
Debug.LogError("There's more than one GridSystemVisual! " + transform + " - " + Instance);
Destroy(gameObject);
return;
}
Instance = this;
}
private void Start()
{
gridSystemVisualSingleArray = new GridSystemVisualSingle[
LevelGrid.Instance.GetWidth(),
LevelGrid.Instance.GetHeight()
];
for (int x = 0; x < LevelGrid.Instance.GetWidth(); x++)
{
for (int z = 0; z < LevelGrid.Instance.GetHeight(); z++)
{
GridPosition gridPosition = new GridPosition(x, z);
Transform gridSystemVisualSingleTransform =
Instantiate(gridSystemVisualSinglePrefab, LevelGrid.Instance.GetWorldPosition(gridPosition), Quaternion.identity);
gridSystemVisualSingleArray[x, z] = gridSystemVisualSingleTransform.GetComponent<GridSystemVisualSingle>();
}
}
UnitActionSystem.Instance.OnSelectedActionChanged += UnitActionSystem_OnSelectedActionChanged;
LevelGrid.Instance.OnAnyUnitMovedGridPosition += LevelGrid_OnAnyUnitMovedGridPosition;
UpdateGridVisual();
}
public void HideAllGridPosition()
{
for (int x = 0; x < LevelGrid.Instance.GetWidth(); x++)
{
for (int z = 0; z < LevelGrid.Instance.GetHeight(); z++)
{
gridSystemVisualSingleArray[x, z].Hide();
}
}
}
private void ShowGridPositionRange(GridPosition gridPosition, int range, GridVisualType gridVisualType)
{
List<GridPosition> gridPositionList = new List<GridPosition>();
for (int x = -range; x <= range; x++)
{
for (int z = -range; z <= range; z++)
{
GridPosition testGridPosition = gridPosition + new GridPosition(x, z);
if (!LevelGrid.Instance.IsValidGridPosition(testGridPosition))
{
continue;
}
int testDistance = Mathf.Abs(x) + Mathf.Abs(z);
if (testDistance > range)
{
continue;
}
gridPositionList.Add(testGridPosition);
}
}
ShowGridPositionList(gridPositionList, gridVisualType);
}
public void ShowGridPositionList(List<GridPosition> gridPositionList, GridVisualType gridVisualType)
{
foreach (GridPosition gridPosition in gridPositionList)
{
gridSystemVisualSingleArray[gridPosition.x, gridPosition.z].
Show(GetGridVisualTypeMaterial(gridVisualType));
}
}
private void UpdateGridVisual()
{
HideAllGridPosition();
Unit selectedUnit = UnitActionSystem.Instance.GetSelectedUnit();
BaseAction selectedAction = UnitActionSystem.Instance.GetSelectedAction();
GridVisualType gridVisualType;
switch (selectedAction)
{
default:
case MoveAction moveAction:
gridVisualType = GridVisualType.White;
break;
case ReloadAction reloadAction:
gridVisualType = GridVisualType.Blue;
break;
case ShootAction shootAction:
gridVisualType = GridVisualType.Red;
ShowGridPositionRange(selectedUnit.GetGridPosition(), shootAction.GetMaxShootDistance(), GridVisualType.RedSoft);
break;
}
ShowGridPositionList(
selectedAction.GetValidActionGridPositionList(), gridVisualType);
}
private void UnitActionSystem_OnSelectedActionChanged(object sender, EventArgs e)
{
UpdateGridVisual();
}
private void LevelGrid_OnAnyUnitMovedGridPosition(object sender, EventArgs e)
{
UpdateGridVisual();
}
private Material GetGridVisualTypeMaterial(GridVisualType gridVisualType)
{
foreach (GridVisualTypeMaterial gridVisualTypeMaterial in gridVisualTypeMaterialList)
{
if (gridVisualTypeMaterial.gridVisualType == gridVisualType)
{
return gridVisualTypeMaterial.material;
}
}
Debug.LogError("Could not find GridVisualTypeMaterial for GridVisualType " + gridVisualType);
return null;
}
}
And here is the GridSystemVisualSingle:
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class GridSystemVisualSingle : MonoBehaviour
{
[SerializeField] private MeshRenderer meshRenderer;
void Awake(){
Hide();
}
public void Show(Material material)
{
meshRenderer.enabled = true;
meshRenderer.material = material;
}
public void Hide()
{
meshRenderer.enabled = false;
}
}
So we’re actually hiding the GridSystemVisualSingles in two places, and they’re still visible after the game starts?
So we know they must be getting hidden, so something is purposely Showing them. Of course, we want to show some valid positions, so that’s what ShowGridPositionList is for. That GridPositionList is generated by getting the selected Action and asking it for it’s GetValidActionGridPositionList(). That’s our next stop.
Since MoveAction is the action that is displayed by default when a Unit is selected, let’s start with that. Paste in your MoveAction.cs script and we’ll go from there.
Here ya go. It’s the same as the video.
using System;
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class MoveAction : BaseAction
{
public event EventHandler OnStartMoving;
public event EventHandler OnStopMoving;
[SerializeField] private int maxMoveDistance = 4;
private Vector3 targetPosition;
protected override void Awake()
{
base.Awake();
targetPosition = transform.position;
}
private void Update()
{
if (!isActive)
{
return;
}
Vector3 moveDirection = (targetPosition - transform.position).normalized;
float stoppingDistance = .1f;
if (Vector3.Distance(transform.position, targetPosition) > stoppingDistance)
{
float moveSpeed = 4f;
transform.position += moveDirection * moveSpeed * Time.deltaTime;
}
else
{
OnStopMoving?.Invoke(this, EventArgs.Empty);
ActionComplete();
}
float rotateSpeed = 10f;
transform.forward = Vector3.Lerp(transform.forward, moveDirection, Time.deltaTime * rotateSpeed);
}
public override void TakeAction(GridPosition gridPosition, Action onActionComplete)
{
ActionStart(onActionComplete);
this.targetPosition = LevelGrid.Instance.GetWorldPosition(gridPosition);
OnStartMoving?.Invoke(this, EventArgs.Empty);
}
public override List<GridPosition> GetValidActionGridPositionList()
{
List<GridPosition> validGridPositionList = new List<GridPosition>();
GridPosition unitGridPosition = unit.GetGridPosition();
for (int x = -maxMoveDistance; x <= maxMoveDistance; x++)
{
for (int z = -maxMoveDistance; z <= maxMoveDistance; z++)
{
GridPosition offsetGridPosition = new GridPosition(x, z);
GridPosition testGridPosition = unitGridPosition + offsetGridPosition;
if (!LevelGrid.Instance.IsValidGridPosition(testGridPosition))
{
continue;
}
if (unitGridPosition == testGridPosition)
{
// Same Grid Position where the unit is already at
continue;
}
if (LevelGrid.Instance.HasAnyUnitOnGridPosition(testGridPosition))
{
// Grid Position already occupied with another Unit
continue;
}
validGridPositionList.Add(testGridPosition);
}
}
return validGridPositionList;
}
public override string GetActionName()
{
return "Move";
}
}I’ll need to take a closer look at this. Zip up your project, without the Library folder and upload it to https://gdev.tv/projectupload and I’ll take a look at it.
Wait, I messed around with it some, and I fixed it! Thank you for your time.
Oh don’t leave in suspense! What was the issue? (and of course, good job on getting it sorted!)