I have gone through the last few lectures to see if there is anything I have missed, but I could not find anything, but I must be missing something. The ‘ActionBusyUI’ is just not showing up when I use the move action, but everything else is working.
Odd that it would be just the MoveAction…
Paste in your UnitActionSystem.cs and we’ll take a look.
Sorry, I’m pretty new to this, I can’t figure out how to paste it in other than copy and pasting it haha.
using System;
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.EventSystems;
public class UnitActionSystem : MonoBehaviour
{
public static UnitActionSystem Instance { get; private set; }
public event EventHandler OnSelectedUnitChanged;
public event EventHandler OnSelectedActionChanged;
public event EventHandler<bool> OnBusyChanged;
[SerializeField] private Unit selectedUnit;
[SerializeField] private LayerMask unitLayerMask;
private BaseAction selectedAction;
private bool isBusy;
private void Awake()
{
if (Instance != null)
{
Debug.LogError("There's more than one UnitActionSystem!" + transform + "-" + Instance);
Destroy(gameObject);
return;
}
Instance = this;
}
private void Start()
{
SetSelectedUnit(selectedUnit);
}
private void Update()
{
if (isBusy)
{
return;
}
if (EventSystem.current.IsPointerOverGameObject())
{
return;
}
if (TryHandleUnitSelection())
{
return;
}
HandleSelectedAction();
}
private void HandleSelectedAction()
{
if (Input.GetMouseButtonDown(0))
{
GridPosition mouseGridPosition = LevelGrid.Instance.GetGridPosition(MouseWorld.GetPosition());
if (selectedAction.IsValidActionGridPosition(mouseGridPosition))
{
SetBusy();
selectedAction.TakeAction(mouseGridPosition, ClearBusy);
}
}
}
private void SetBusy()
{
isBusy = true;
OnBusyChanged?.Invoke(this, isBusy);
}
private void ClearBusy()
{
isBusy = false;
OnBusyChanged?.Invoke(this, isBusy);
}
private bool TryHandleUnitSelection()
{
if (Input.GetMouseButtonDown(0))
{
Ray ray = Camera.main.ScreenPointToRay(Input.mousePosition);
if (Physics.Raycast(ray, out RaycastHit raycastHit, float.MaxValue, unitLayerMask))
{
if (raycastHit.transform.TryGetComponent<Unit>(out Unit unit))
{
if (unit == selectedUnit)
{
// Unit is already selected
return false;
}
SetSelectedUnit(unit);
return true;
}
}
}
return false;
}
private void SetSelectedUnit (Unit unit)
{
selectedUnit = unit;
SetSelectedAction(unit.GetMoveAction());
OnSelectedUnitChanged?.Invoke(this, EventArgs.Empty);
}
public void SetSelectedAction(BaseAction baseAction)
{
selectedAction = baseAction;
OnSelectedActionChanged?.Invoke(this, EventArgs.Empty);
}
public Unit GetSelectedUnit()
{
return selectedUnit;
}
public BaseAction GetSelectedAction()
{
return selectedAction;
}
}
``` <<< Added this to end code blockCopying and pasting is pretty much the best way to do it.
If you put three backwards apostrophes (the key to the left of the 1 button on your keyboard) on a line immediately before the code and immediately after the code, the message board will format the code for you. I’ve taken the liberty of editing your post for this. If you click Edit, you’ll see what I did.
2 Likes
So far, the code looks right, we’re calling SetBusy right when the action occurs, and then passing the SetClear as the message when the action is completed.
So that leads me to suspect that MoveAction is calling the callback too early. Paste in the MoveAction.cs and we’ll take a look.
1 Like
Thank you so much!
Here is my MoveAction.cs
using System;
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class MoveAction : BaseAction
{
[SerializeField] private Animator unitAnimator;
[SerializeField] private int maxMoveDistance = 4;
private Vector3 targetPosition;
protected override void Awake()
{
base.Awake();
targetPosition = transform.position;
}
private void Update()
{
if(!isActive)
{
return;
}
Vector3 moveDirection = (targetPosition - transform.position).normalized;
float stoppingDistance = .1f;
if (Vector3.Distance(transform.position, targetPosition) > stoppingDistance)
{
float moveSpeed = 4f;
transform.position += moveDirection * moveSpeed * Time.deltaTime;
unitAnimator.SetBool("IsWalking", true);
}
else
{
unitAnimator.SetBool("IsWalking", false);
isActive = false;
}
float rotateSpeed = 10f;
transform.forward = Vector3.Lerp(transform.forward, moveDirection, Time.deltaTime * rotateSpeed);
}
public override void TakeAction(GridPosition gridPosition, Action onActionComplete)
{
this.onActionComplete = onActionComplete;
this.targetPosition = LevelGrid.Instance.GetWorldPosition(gridPosition);
isActive = true;
onActionComplete();
}
public override List<GridPosition> GetValidActionGridPositionList()
{
List<GridPosition> validGridPositionList = new List<GridPosition>();
GridPosition unitGridPosition = unit.GetGridPosition();
for (int x = -maxMoveDistance; x <= maxMoveDistance; x++)
{
for (int z = -maxMoveDistance; z <= maxMoveDistance; z++)
{
GridPosition offsetGridPosition = new GridPosition(x, z);
GridPosition testGridPosition = unitGridPosition + offsetGridPosition;
if (!LevelGrid.Instance.IsValidGridPosition(testGridPosition))
{
continue;
}
if (unitGridPosition == testGridPosition)
{
//same Grid Position where the unit is already at
continue;
}
if (LevelGrid.Instance.HasAnyUnitOnGridPosition(testGridPosition))
{
// Grid position already occupied with another unit
continue;
}
validGridPositionList.Add(testGridPosition);
}
}
return validGridPositionList;
}
public override string GetActionName()
{
return "Move";
}
}
I suspect this is why, OnActionComplete() is being called right away, which goes back into UnitActionScheduler and sets ClearBusy.
Instead, consider putting OnActionComplete in the UpdateMethod where we set isActive to False:
1 Like
This worked perfectly! Thank you so much
This topic was automatically closed 20 days after the last reply. New replies are no longer allowed.