Configuring the gun in UE 4.19

Unreal Courses Talk
,
#1

I’ve just done this so haven’t fully thought if there is a better way, but possibly due to changes in 4.19 or earlier, the solution of moving the gun binding into begin play was a bit problematic as the player input component isn’t available (at least not readily). Here is an alternative:

void AFirstPersonCharacter::OnFire()
{
    if (Gun)
    {
        Gun->OnFire();
    }
}

void AFirstPersonCharacter::SetupPlayerInputComponent(class UInputComponent* PlayerInputComponent)
{
	// set up gameplay key bindings
	check(PlayerInputComponent);

	// Bind jump events
	PlayerInputComponent->BindAction("Jump", IE_Pressed, this, &ACharacter::Jump);
	PlayerInputComponent->BindAction("Jump", IE_Released, this, &ACharacter::StopJumping);

        PlayerInputComponent->BindAction("Fire", IE_Pressed, this, &AFirstPersonCharacter::OnFire);
#2

I also have this issue. I think I know why Sam is moving the input binding to BeginPlay(). I’m assuming that because we set up
Gun = GetWorld()->SpawnActor<AGun>(GunBlueprint); Gun->AttachToComponent(Mesh1P, FAttachmentTransformRules(EAttachmentRule::SnapToTarget, true), TEXT("GripPoint"));
in BeginPlay, our Gun is out of scope when we bind it in SetupPlayerInputComponent(…).

I’m think if we were promote our setup of Gun to a global? variable, it would solve the problem, but I’m not entirely sure how it will play out and I don’t want to veer too far off course. I’ll just use your solution for now. Thanks!

#3

One solution I did is to place the attachment code right before we set up the binding. like so

//attach the gun mesh component to the skeleton
if (m_gun_bp == NULL) { return; }

if (m_gun == NULL) 
{
 m_gun = GetWorld()->SpawnActor<AGun>(m_gun_bp);
 m_gun->AttachToComponent(Mesh1P, FAttachmentTransformRules(EAttachmentRule::SnapToTarget, true), TEXT("GripPoint"));
 m_gun->AnimInstance = Mesh1P->GetAnimInstance();
}

// Bind fire 
PlayerInputComponent->BindAction("Fire", IE_Pressed, m_gun, &AGun::OnFire);

Hope this helps

1 Like
#4

To me this one should be the solution.

SetupPlayerInputComponent is meant to be used:

Blockquote
Allows a Pawn to set up custom input bindings. Called upon possession by a PlayerController, using the InputComponent created by CreatePlayerInputComponent() .

So Binding an input on BeginPlay looks not so good.

+1 for Picaro solution

#5

This definitely worked for me. a snippet of my FirstPersonCharacter.cpp file:

// Copyright 1998-2018 Epic Games, Inc. All Rights Reserved.

#include "FirstPersonCharacter.h"
#include "Engine/World.h"
#include "Camera/CameraComponent.h"
#include "Components/CapsuleComponent.h"
#include "Components/InputComponent.h"
#include "GameFramework/InputSettings.h"
#include "HeadMountedDisplayFunctionLibrary.h"
#include "../Weapons/Gun.h"


DEFINE_LOG_CATEGORY_STATIC(LogFPChar, Warning, All);

//////////////////////////////////////////////////////////////////////////
// AFirstPersonCharacter

AFirstPersonCharacter::AFirstPersonCharacter()
{
	// Set size for collision capsule
	GetCapsuleComponent()->InitCapsuleSize(55.f, 96.0f);

	// set our turn rates for input
	BaseTurnRate = 45.f;
	BaseLookUpRate = 45.f;

	// Create a CameraComponent	
	FirstPersonCameraComponent = CreateDefaultSubobject<UCameraComponent>(TEXT("FirstPersonCamera"));
	FirstPersonCameraComponent->SetupAttachment(GetCapsuleComponent());
	FirstPersonCameraComponent->RelativeLocation = FVector(-39.56f, 1.75f, 64.f); // Position the camera
	FirstPersonCameraComponent->bUsePawnControlRotation = true;

	// Create a mesh component that will be used when being viewed from a '1st person' view (when controlling this pawn)
	Mesh1P = CreateDefaultSubobject<USkeletalMeshComponent>(TEXT("CharacterMesh1P"));
	Mesh1P->SetOnlyOwnerSee(true);
	Mesh1P->SetupAttachment(FirstPersonCameraComponent);
	Mesh1P->bCastDynamicShadow = false;
	Mesh1P->CastShadow = false;
	Mesh1P->RelativeRotation = FRotator(1.9f, -19.19f, 5.2f);
	Mesh1P->RelativeLocation = FVector(-0.5f, -4.4f, -155.7f);

	// Default offset from the character location for projectiles to spawn
	GunOffset = FVector(100.0f, 0.0f, 10.0f);
}

void AFirstPersonCharacter::BeginPlay()
{
	// Call the base class  
	Super::BeginPlay();
	//Attach gun mesh component to Skeleton, doing it here because the skeleton is not yet created in the constructor
    if (GunBlueprint == NULL) 
    {
        UE_LOG(LogTemp, Warning, TEXT("GunBlueprint not found"));
        return;
    }
    //FP_Gun = GetWorld()->SpawnActor<AGun>(GunBlueprint);
    //FP_Gun->AttachToComponent(Mesh1P, FAttachmentTransformRules(EAttachmentRule::SnapToTarget, true), TEXT("GripPoint"));
}

//////////////////////////////////////////////////////////////////////////
// Input

void AFirstPersonCharacter::SetupPlayerInputComponent(class UInputComponent* PlayerInputComponent)
{
	// set up gameplay key bindings
	check(PlayerInputComponent);

	// Bind jump events
	PlayerInputComponent->BindAction("Jump", IE_Pressed, this, &ACharacter::Jump);
	PlayerInputComponent->BindAction("Jump", IE_Released, this, &ACharacter::StopJumping);

    if (FP_Gun == NULL)
    {
        FP_Gun = GetWorld()->SpawnActor<AGun>(GunBlueprint);
        FP_Gun->AttachToComponent(Mesh1P, FAttachmentTransformRules(EAttachmentRule::SnapToTarget, true), TEXT("GripPoint"));
        FP_Gun->AnimInstance = Mesh1P->GetAnimInstance();
    }
    
	// Bind fire event
	//PlayerInputComponent->BindAction("Fire", IE_Pressed, this, &AFirstPersonCharacter::OnFire);
	PlayerInputComponent->BindAction("Fire", IE_Pressed, FP_Gun, &AGun::OnFire);

	// Enable touchscreen input
	EnableTouchscreenMovement(PlayerInputComponent);

	PlayerInputComponent->BindAction("ResetVR", IE_Pressed, this, &AFirstPersonCharacter::OnResetVR);

	// Bind movement events
	PlayerInputComponent->BindAxis("MoveForward", this, &AFirstPersonCharacter::MoveForward);
	PlayerInputComponent->BindAxis("MoveRight", this, &AFirstPersonCharacter::MoveRight);

	// We have 2 versions of the rotation bindings to handle different kinds of devices differently
	// "turn" handles devices that provide an absolute delta, such as a mouse.
	// "turnrate" is for devices that we choose to treat as a rate of change, such as an analog joystick
	PlayerInputComponent->BindAxis("Turn", this, &APawn::AddControllerYawInput);
	PlayerInputComponent->BindAxis("TurnRate", this, &AFirstPersonCharacter::TurnAtRate);
	PlayerInputComponent->BindAxis("LookUp", this, &APawn::AddControllerPitchInput);
	PlayerInputComponent->BindAxis("LookUpRate", this, &AFirstPersonCharacter::LookUpAtRate);
}

Privacy & Terms