I did it!

Unity Courses Talk
, ,
#9

hehe… ok, now this I will definitely have to see, please feel free to tag me (@Rob) so I don’t miss it :slight_smile:

#10

I will keep you posted :smiley:

1 Like
#11

@Rob i fixed the spelling mistakes, and someone else noticed that when they pressed backspace it registered twice. so when i was making corrections i was looking for any errors that might cause that. then when i was testing i noticed that in unity the backspace registers once as it should, but as soon as i build with OpenGL and upload to ShareMyGame the backspace registers twice. any ideas?

#12

This is actually an issue with the code provided to you in this section. I have raised this with Ben previously but it doesn’t look like it got resolved. The behaviour comes from the WM2000 code that you use in this project.

#13

Oh Good! when it was raised in the discord i said that because i couldn’t find it i thought it must be something in the project files as that’s where the typing behaviour must be. thank you for confirming that. gives me confidence in my own logic lol

1 Like
#14

I’ve just downloaded the WM2000 Unity Package from the course, I’ll take a quick look through and see if I can find anything.

I would have thought this behaviour would happen when you run the game within Unity also though, does it not?

#15

no, only once it’s been built with OpenGL

1 Like
#16

hmmm, curious…

Ok, I’ll have a quick look and see if there’s anything that I can see… seems odd…

#17

i just had a poke around (i am a complete novice though) and the delete command is in the inputBuffer.cs but it all seems fine. do you think its an OpenGL issue?

1 Like
#18

Hi,

Ok, so I spent a lot longer messing with this than I really should have! If you make the following change to Keyboard.cs;

private void Update()
{
    bool isValidKey = Input.inputString.Length > 0;
    if (isValidKey)
    {
        PlayRandomSound();
    }
    if (connectedToTerminal)
    {
        if (Input.anyKeyDown)    // returns true the first frame the user hits any key
        {
            connectedToTerminal.ReceiveFrameInput(Input.inputString);
        }
    }
}

Hope this helps :slight_smile:

See also;

#19

Ok so i have corrected the bug and also found and fixed another bug. so if you hold down the backspace with the current code, it will loop and play the keystroke sound over and over. so from the info you gave me i did this:

key stroke sound repeat bug fix
key stroke sound repeat _bug fix_.JPG799×270 20.4 KB

considering this game is the first piece of coding I’ve EVER done, I think I’ve learnt a good amount. 5 star course so far. thanks @Rob i’m going to make another post in this section with the bug fixed version of the finished project

2 Likes
Reviewed after player input
#20

Hey Sean,

Great to see you are experimenting and making changes, this confidence will continue to grow I am certain :slight_smile:

Regarding whether this is a bug or not, I did wonder about also making a chance to this;

    if (isValidKey)
    {
        PlayRandomSound();
    }

…in the Update method yesterday, but a) I figured this wasn’t really the bug we were discussing and b) keyboards still make a sound when you tap a key even if there isn’t something to change on the screen, so I left it :slight_smile:

considering this game is the first piece of coding I’ve EVER done, I think I’ve learnt a good amount. 5 star course so far.

I’m sure @ben and the team will be delighted to hear this Sean, if you haven’t already, perhaps at some point consider adding a review to the course on Udemy :slight_smile:

#21

I’m glad you didn’t fix the sound. Gave me the opportunity to discover and fix it myself lol.

I haven’t left a review yet, but i certainly will. I’m really enjoying it. The community set up has been great too. Love it

1 Like
#22

I’m glad you didn’t fix the sound. Gave me the opportunity to discover and fix it myself lol.

:+1:

I haven’t left a review yet, but i certainly will. I’m really enjoying it. The community set up has been great too. Love it

Really great to hear, thanks Sean :slight_smile:

#23

Turns out I had left a very brief review in the first day or 2. but I’ve been so impressed and I’m so happy with the course so far that I had to edit it

2 Likes
#24

Turns out I had left a very brief review in the first day or 2. but I’ve been so impressed and I’m so happy with the course so far that I had to edit it

Awesome, thanks Sean, all of the positive reviews and great feedback help the team to keep creating more great content and courses :slight_smile:

3 Likes
#25

Great job! It was fun to play. I like your theme and the art you did

2 Likes
#26

I really likes your theme and skull.

1 Like
#27

thank you :slight_smile:

1 Like
#28

Sorry I let it slip through when you caught it early Rob!

2 Likes

Privacy & Terms